enhance ee.Image.fullLike #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test failure is weird since the failing test is not using the modified method at all 🤔 |
|
The test failure is related to GEE slightly changing it's rounding method all the time, you must nuke the nox folder from your side and start the complete test suit again to regenerate the file. I would like to have a better way of testing this with pytest-gee but never found the time to work on it yet. |
12rambau
requested changes
May 16, 2024
12rambau
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ee.Projectionnot only stores the CRS but also the nominal scale, and although the CRS is usually constant across all bands, is not the same for the nominal scale (example here). So, one of the modification of this PR is to copy each band's projection to the image generated byee.Image.fullLike.In the previous version of
fullLikethe footprint of the original images was passed to the resulting image. Now the user can choose whether to copy it or not, giving more flexibility to the user.