add feature_groups() plotting function in chart.py file #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging e74cee8 into f094e74 - view on LGTM.com fixed alerts:
|
|
@3r3n-n Awesome work! Thank you very much for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
chart.feature_groups()function was implemented using bqplot and a bit of pandas in the chart.py file, addressing issue #339.This new function was manually and visually tested against the GEE JavaScript API example (see images below), Tooltips also work.
The respective changes passed the tox tests for python 3.5, 3.6, 3.7 and 3.8. It failed in flake8 test... however, the intact cloned repo (before any changes) also failed with the same errors, which are related to files and lines that were not modified in this PR.
chart from this PR (displayed on Jupyter Lab):
chart from the JavaScript API (ui.Chart.feature.groups):