Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility - Favourites dialog box keyboard navigation #1737

Closed
wants to merge 6 commits into from

Conversation

e218736
Copy link
Contributor

@e218736 e218736 commented Feb 26, 2024

Issue
Issue #1718

This PR aims to solve some of the 'limited keyboard interaction' outlined in section 4/5 of keyboard Navigation in the issue linked above, focusing on the Edit favourites dialog box. E.g. Inability to focus on menu items and view tooltips through tabbing, use of arrow keys for navigation and Lack of keyboard alternative for drag-and-drop operations

Code changes:

  • TabIndex=0 added to elements within the Edit Favourites dialog
  • On focus styling of elements with tooltips to match mouse hover
  • Keydown event listeners added to favourite operations
  • Function added to enable reordering of favorite operation using CTRL + arrow keys to mimic mouse drag function
  • Arrow navigation of favourite items implemented

User-facing changes:

  • tooltips show on focus
  • reorder instructions within dialog updated to include keyboard navigation

To replicate:

  • Open favourites dialog with mouse click (keyboard functionality is being implemented in separate PR)
  • Tab to first operation
  • Press up/down arrow to navigate through the list (should loop back to top/bottom)
  • press Arrow Right on any operation and either Arrow Left to focus back on the operation or Enter/ Space to delete from list
  • pressing Ctrl+ Up Arrow / Down Arrow should move the focused operation up or down the list (should loop back to top/bottom)
  • Press Tab to exit the list of operations and either reset/save/or cancel

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2024

CLA assistant check
All committers have signed the CLA.

@e218736 e218736 marked this pull request as ready for review February 27, 2024 13:03
@e218736
Copy link
Contributor Author

e218736 commented Mar 1, 2024

This Pr has been merged into #1724 to ensure functionally applies across current click events and key press events implemented in #1724

@a3957273
Copy link
Member

Closing as handling under #1724

@a3957273 a3957273 closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants