Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct description of SC clock speed switch #548

Merged
merged 1 commit into from Apr 18, 2024

Conversation

quinnyo
Copy link
Contributor

@quinnyo quinnyo commented Apr 17, 2024

This is a pretty straightforward error correction. It didn't seem worth making an issue for it first, hopefully that's OK.

The change is to the description of the serial clock speed selector (bit 1, register SC).
The erroneous description stated that the optional higher speed was a doubling in frequency, but the actual behaviour is switching between the standard 8 kHz and the ridiculous 256 kHz (32ing it!).
The new description is also now in accord with the table of clock frequencies a little bit further down, under the Internal Clock heading.

(The serial clock frequency is also doubled by the system double-speed mode, which may be where some confusion came from)

@avivace avivace requested a review from ISSOtm April 17, 2024 18:12
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! No problem with not opening an issue for changes this small :)

@ISSOtm ISSOtm merged commit 62ecae4 into gbdev:master Apr 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants