Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SGB output lines documentation #547

Merged
merged 3 commits into from Mar 20, 2024
Merged

Fix SGB output lines documentation #547

merged 3 commits into from Mar 20, 2024

Conversation

Zarithya
Copy link
Contributor

Fixes #546.

ISSOtm
ISSOtm requested changes Mar 20, 2024
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is importing the wording from the historical doc? I suggest rewording it a little so it's a bit clearer.

Thank you for this PR! ^^

src/SGB_Command_Packet.md Outdated Show resolved Hide resolved
@Zarithya @ISSOtm
Update src/SGB_Command_Packet.md
357fa39 
Co-authored-by: Eldred Habert <eldredhabert0@gmail.com>
@Zarithya
Copy link
Contributor Author

@ISSOtm Wasn't sure what wording to use there so I erred on the side of using the same wording as the old doc. I've accepted your change into the PR.

@ISSOtm
Copy link
Member

ISSOtm commented Mar 20, 2024

(GitHub tip: you can dismiss a review and then re-request it!)

ISSOtm
ISSOtm approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ISSOtm ISSOtm merged commit 5dbce5b into gbdev:master Mar 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avivace avivace avivace approved these changes

@ISSOtm ISSOtm ISSOtm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SGB command packet transfers are described using wrong bits of JOYP
3 participants
@Zarithya @ISSOtm @avivace