Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed special char display problem #24

Merged
merged 2 commits into from Dec 11, 2016

Conversation

aharshac
Copy link
Contributor

@aharshac aharshac commented Dec 6, 2016

Fixes: #22

@gautamkrishnar
Copy link
Owner

@aharshac Thank you for your contribution. I will review this one once I reach my home.

@gautamkrishnar
Copy link
Owner

We need to display the single quotes and double quotes in the question title... Will it be replaced by this regex?

@aharshac
Copy link
Contributor Author

aharshac commented Dec 7, 2016

@gautamkrishnar, no I haven't fixed that because I didn't know your exact requirements at that time. Please send them to me.

@gautamkrishnar
Copy link
Owner

We need to display the double quotes and single quotes in the question title. Please modify the regular expression to ignore that too... Also all the common punctuators and separators used in programming languages.

@aharshac
Copy link
Contributor Author

aharshac commented Dec 9, 2016

Please read the thread in Collaborizm. I've explained a possible fix there.

@gautamkrishnar
Copy link
Owner

@aharshac okay let me check!

@gautamkrishnar
Copy link
Owner

gautamkrishnar commented Dec 9, 2016

@aharshac I saw your reply on collaborizm, can you fix it yourself?. Please don't add any new dependencies,
Here's a reference link: http://stackoverflow.com/questions/3592673/change-console-font-in-windows

@aharshac
Copy link
Contributor Author

Ok. I'll push by tonight.

@gautamkrishnar gautamkrishnar merged commit ebdd020 into gautamkrishnar:master Dec 11, 2016
@gautamkrishnar
Copy link
Owner

Thank you for your contribution. I had made some updates to execute the chcp command as well. 😄 Now the bug is almost fixed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants