chore(gatsby-cli): bundle ink logger #26887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
added
the
type: maintenance
gatsbot
bot
added
the
status: triage needed
pieh
removed
the
status: triage needed
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 25m |
pieh
force-pushed
the
chore/bundle-cli
branch
from
6828bad
to
379704b
Compare
This is needed for PnP as setting `yoga-layout-prebuilt` as external imports it from node_modules, but it's not declared by gatsby-cli itself. Alternatively we could bundle it too, but this has problems too: facebook/yoga#798 the solution there is pretty hacky and I would rather not use it.
pieh
commented
Sep 14, 2020
Comment on lines
+63
to
+67
| // Next one deserve explanation: ... it's because ink logger imports | ||
| // getStore, onLogAction from higher up (../../redux). But we don't want | ||
| // two copies of it - one bundled and one not, because it would result | ||
| // in multiple store copies | ||
| `../../redux` |
There was a problem hiding this comment.
adding inline comment here to highlight this - this is the most fragile part of this setup
wardpeet
previously approved these changes
Sep 14, 2020
wardpeet
previously approved these changes
Sep 14, 2020
wardpeet
approved these changes
Sep 15, 2020
|
Published in |
gatsbybot
pushed a commit
that referenced
this pull request
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR looks to bundle parts of
gatsby-cliwhich useinkandreact. In some scenarios multiple versions ofreactcan be installed innode_modulesand this can lead to very weird errors and warnings related to multiple react instances. This change work around it, so react is being bundled and is part of published npm package instead as dependency that users need to download.For more information check on description of #21522 which highlights some problems with multiple versions of
react(it seems that peerDependency is not really honored bynpmwhen resolvingnode_moduleshierarchy and this is why it cause such a problems).Related Issues
Related to #19827, #21522