Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow accesing server over the network by default #13128

Closed
wants to merge 1 commit into from
Closed

allow accesing server over the network by default #13128

wants to merge 1 commit into from

Conversation

pgarciacamou
Copy link

Description

Add -H 0.0.0.0 as default to the templates when running the develop script.

Related Issues

#5801 (comment)

@pgarciacamou pgarciacamou requested a review from a team as a code owner April 4, 2019 18:02
@DSchau
Copy link
Contributor

DSchau commented Apr 4, 2019

Hey!

Thanks for this--but unfortunately I don't think we're going to merge this.

Specifically, while this does seem to be a reasonable change for some small percentage of users, it's probably not a reasonable change for all users.

If you think this is something that could be improved as far as documentation, we'd love to see that!

We absolutely want to have you as a contributor, so please take a look at our open issues for ideas, and please reach out to us on Twitter at @gatsbyjs with questions.

We offer pair programming sessions if you’d like to work with one of our maintainers to make your first contribution.

Thanks again, and we look forward to seeing more PRs from you in the future! 💪💜

@DSchau DSchau closed this Apr 4, 2019
@pgarciacamou pgarciacamou deleted the patch-1 branch April 5, 2019 17:26
@pgarciacamou
Copy link
Author

Thanks for taking a look @DSchau 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants