Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): pin webpack to fix unexpected token error during build #11640

Merged
merged 2 commits into from Feb 8, 2019

Conversation

paulmelnikow
Copy link
Contributor

Description

This addresses #11198.

There's a regression bug webpack/webpack#8656 affecting 4.29.0 through at least 4.29.3 which causes errors like this during gatsby build.

Error: ./.cache/async-requires.js 8:11
Module parse failed: Unexpected token (8:11)
You may need an appropriate loader to handle this file type.
| exports.components = {
| "component---frontend-components-main-js": function componentFrontendCompo nentsMainJs() {

return import("/home/circleci/project/frontend/components/main.js"

| /* webpackChunkName: "component---frontend-components-main-js" */
| );
@ ./.cache/production-app.js 18:0-45 21:23-36 26:23-36

Related Issues

@paulmelnikow paulmelnikow requested a review from a team as a code owner February 8, 2019 02:39
This addresses gatsbyjs#11198.

There's a regression bug webpack/webpack#8656 affecting 4.29.0 through at least 4.29.3 which causes errors like this during `gatsby build`.

  Error: ./.cache/async-requires.js 8:11
  Module parse failed: Unexpected token (8:11)
  You may need an appropriate loader to handle this file type.
  | exports.components = {
  |   "component---frontend-components-main-js": function componentFrontendCompo  nentsMainJs() {
  >     return import("/home/circleci/project/frontend/components/main.js"
  |     /* webpackChunkName: "component---frontend-components-main-js" */
  |     );
   @ ./.cache/production-app.js 18:0-45 21:23-36 26:23-36
packages/gatsby/package.json Outdated Show resolved Hide resolved
Co-Authored-By: paulmelnikow <github@paulmelnikow.com>
@DSchau DSchau changed the title fix(gatsby): Pin webpack to fix gatsby build problem fix(gatsby): pin webpack to fix unexpected token error during build Feb 8, 2019
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for identifying the fix and opening this PR!

Was able to validate with the Shields repo that this is an issue--so this will be a quick little band-aid until Webpack and Acorn iron out the issue here.

@DSchau DSchau merged commit f460b7f into gatsbyjs:master Feb 8, 2019
@DSchau
Copy link
Contributor

DSchau commented Feb 8, 2019

Successfully published:
 - gatsby@2.0.118

@paulmelnikow paulmelnikow deleted the gatsby/downgrade-webpack branch February 8, 2019 18:02
gurpreet-hanjra pushed a commit to gurpreet-hanjra/gatsby that referenced this pull request Feb 14, 2019
…atsbyjs#11640)

## Description

This addresses gatsbyjs#11198.

There's a regression bug webpack/webpack#8656 affecting 4.29.0 through at least 4.29.3 which causes errors like this during `gatsby build`.

  Error: ./.cache/async-requires.js 8:11
  Module parse failed: Unexpected token (8:11)
  You may need an appropriate loader to handle this file type.
  | exports.components = {
  |   "component---frontend-components-main-js": function componentFrontendCompo  nentsMainJs() {
  >     return import("/home/circleci/project/frontend/components/main.js"
  |     /* webpackChunkName: "component---frontend-components-main-js" */
  |     );
   @ ./.cache/production-app.js 18:0-45 21:23-36 26:23-36

<!--
  Have any questions? Check out the contributing docs at https://gatsby.app/contribute, or
  ask in this Pull Request and a Gatsby maintainer will be happy to help :)
-->

## Related Issues

- Addresses gatsbyjs#11198
- Related to webpack/webpack#8656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants