Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/prometheus/client_golang to v1.19.1 #9729

Conversation

gardener-ci-robot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
github.com/prometheus/client_golang require minor v1.18.0 -> v1.19.1

Release Notes

prometheus/client_golang (github.com/prometheus/client_golang)

v1.19.1

Compare Source

What's Changed

  • Security patches for golang.org/x/sys and google.golang.org/protobuf

New Contributors

Full Changelog: prometheus/client_golang@v1.19.0...v1.19.1

v1.19.0

Compare Source

What's Changed

The module prometheus/common v0.48.0 introduced an incompatibility when used together with client_golang (See https://github.com/prometheus/client_golang/pull/1448 for more details). If your project uses client_golang and you want to use prometheus/common v0.48.0 or higher, please update client_golang to v1.19.0.

  • [CHANGE] Minimum required go version is now 1.20 (we also test client_golang against new 1.22 version). #​1445 #​1449
  • [FEATURE] collectors: Add version collector. #​1422 #​1427

New Contributors

Full Changelog: prometheus/client_golang@v1.18.0...v1.19.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@gardener-ci-robot gardener-ci-robot added the kind/enhancement Enhancement, improvement, extension label May 9, 2024
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels May 9, 2024
Copy link
Contributor

gardener-prow bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign plkokanov for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot requested review from ary1992 and timuthy May 9, 2024 12:05
@gardener-prow gardener-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 9, 2024
Copy link
Contributor

gardener-prow bot commented May 9, 2024

@gardener-ci-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-verify-image-build 2cb015c link true /test pull-gardener-verify-image-build
pull-gardener-integration 2cb015c link true /test pull-gardener-integration
pull-gardener-e2e-kind-migration 2cb015c link true /test pull-gardener-e2e-kind-migration
pull-gardener-e2e-kind-operator 2cb015c link true /test pull-gardener-e2e-kind-operator
pull-gardener-e2e-kind-migration-ha-single-zone 2cb015c link true /test pull-gardener-e2e-kind-migration-ha-single-zone
pull-gardener-e2e-kind-ipv6 2cb015c link true /test pull-gardener-e2e-kind-ipv6
pull-gardener-e2e-kind-ha-multi-zone 2cb015c link true /test pull-gardener-e2e-kind-ha-multi-zone
pull-gardener-e2e-kind-ha-single-zone 2cb015c link true /test pull-gardener-e2e-kind-ha-single-zone
pull-gardener-e2e-kind 2cb015c link true /test pull-gardener-e2e-kind
pull-gardener-unit 2cb015c link true /test pull-gardener-unit
pull-gardener-e2e-kind-upgrade 2cb015c link true /test pull-gardener-e2e-kind-upgrade
pull-gardener-e2e-kind-ha-multi-zone-upgrade 2cb015c link true /test pull-gardener-e2e-kind-ha-multi-zone-upgrade
pull-gardener-e2e-kind-ha-single-zone-upgrade 2cb015c link true /test pull-gardener-e2e-kind-ha-single-zone-upgrade

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rfranzke
Copy link
Member

Seems to be incompatible with k8s.io/component-base@v0.29.3:

Building github.com/gardener/gardener/cmd/gardener-resource-manager for linux/amd64
Unexpected error running "go build": exit status 1
# k8s.io/component-base/metrics/testutil
../../../../pkg/mod/k8s.io/component-base@v0.29.3/metrics/testutil/metrics.go:73:59: undefined: expfmt.FmtText
Build [europe-docker.pkg.dev/gardener-project/releases/gardener/apiserver] failed: could not build and publish ko image "europe-docker.pkg.dev/gardener-project/releases/gardener/apiserver": failed to publish ko image: error building "ko://github.com/gardener/gardener/cmd/gardener-apiserver": build: go build: exit status 1

/close

@gardener-prow gardener-prow bot closed this May 10, 2024
Copy link
Contributor

gardener-prow bot commented May 10, 2024

@rfranzke: Closed this PR.

In response to this:

Seems to be incompatible with k8s.io/component-base@v0.29.3:

Building github.com/gardener/gardener/cmd/gardener-resource-manager for linux/amd64
Unexpected error running "go build": exit status 1
# k8s.io/component-base/metrics/testutil
../../../../pkg/mod/k8s.io/component-base@v0.29.3/metrics/testutil/metrics.go:73:59: undefined: expfmt.FmtText
Build [europe-docker.pkg.dev/gardener-project/releases/gardener/apiserver] failed: could not build and publish ko image "europe-docker.pkg.dev/gardener-project/releases/gardener/apiserver": failed to publish ko image: error building "ko://github.com/gardener/gardener/cmd/gardener-apiserver": build: go build: exit status 1

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rfranzke rfranzke deleted the renovate/github.com-prometheus-client_golang-1.x branch May 10, 2024 05:41
@gardener-ci-robot
Copy link
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (v1.19.1). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants