Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module gomodules.xyz/jsonpatch/v2 to v3 #9516

Closed

Conversation

gardener-ci-robot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
gomodules.xyz/jsonpatch/v2 require major v2.4.0 -> v3.0.1

Release Notes

gomodules/jsonpatch (gomodules.xyz/jsonpatch/v2)

v3.0.1

Compare Source

This release uses our forked gomodules/orderedmap library. Our forked version has 2 major changes:

  • Uses *OrderedMap instead of OrderedMap inside nested orderedmaps.
  • I ported unstructured helpers from Kubernetes to work with orderedmaps.

v3.0.0

Compare Source

This release uses iancoleman/orderedmap to generate predictable patch. This is very useful if the generated patch is checked into a VCS like git.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@gardener-ci-robot gardener-ci-robot added the kind/enhancement Enhancement, improvement, extension label Apr 3, 2024
@gardener-ci-robot
Copy link
Contributor Author

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: go.sum
Command failed: go get -d -t ./...
go: gomodules.xyz/jsonpatch/v2/v3@v3.0.1: unrecognized import path "gomodules.xyz/jsonpatch/v2/v3": reading https://gomodules.xyz/jsonpatch/v2/v3?go-get=1: 404 Not Found

Copy link
Contributor

gardener-prow bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign plkokanov for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Apr 3, 2024
@gardener-prow gardener-prow bot requested review from ary1992 and timuthy April 3, 2024 13:07
@gardener-prow gardener-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 3, 2024
Copy link
Contributor

gardener-prow bot commented Apr 3, 2024

@gardener-ci-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-unit 40f7064 link true /test pull-gardener-unit
pull-gardener-integration 40f7064 link true /test pull-gardener-integration
pull-gardener-verify-image-build 40f7064 link true /test pull-gardener-verify-image-build
pull-gardener-e2e-kind-operator 40f7064 link true /test pull-gardener-e2e-kind-operator
pull-gardener-e2e-kind 40f7064 link true /test pull-gardener-e2e-kind
pull-gardener-e2e-kind-ha-multi-zone 40f7064 link true /test pull-gardener-e2e-kind-ha-multi-zone
pull-gardener-e2e-kind-ha-single-zone 40f7064 link true /test pull-gardener-e2e-kind-ha-single-zone
pull-gardener-e2e-kind-migration 40f7064 link true /test pull-gardener-e2e-kind-migration
pull-gardener-e2e-kind-migration-ha-single-zone 40f7064 link true /test pull-gardener-e2e-kind-migration-ha-single-zone
pull-gardener-e2e-kind-ha-multi-zone-upgrade 40f7064 link true /test pull-gardener-e2e-kind-ha-multi-zone-upgrade
pull-gardener-e2e-kind-ha-single-zone-upgrade 40f7064 link true /test pull-gardener-e2e-kind-ha-single-zone-upgrade
pull-gardener-e2e-kind-upgrade 40f7064 link true /test pull-gardener-e2e-kind-upgrade

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oliver-goetz
Copy link
Member

This update is not compatible with controller-runtime.
/close

Copy link
Contributor

gardener-prow bot commented Apr 4, 2024

@oliver-goetz: Closed this PR.

In response to this:

This update is not compatible with controller-runtime.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gardener-prow gardener-prow bot closed this Apr 4, 2024
@gardener-ci-robot
Copy link
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 3.x releases. But if you manually upgrade to 3.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@gardener-ci-robot gardener-ci-robot deleted the renovate/gomodules.xyz-jsonpatch-v2-3.x branch April 4, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants