Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GEP-20] Update the existing recovery mechanisms in the proposal #6732

Merged
merged 1 commit into from Oct 24, 2022
Merged

[GEP-20] Update the existing recovery mechanisms in the proposal #6732

merged 1 commit into from Oct 24, 2022

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/area high-availability
/kind enhancement

What this PR does / why we need it:
Previously there was the misunderstanding that in case of a Node/zone outage Pods on unhealthy Nodes hang forever in Terminating state and that we have to enhance/implement garbage collection logic for this case.
This PR updates the existing recovery mechanisms and describes the observations from #6529 (comment) and #6529 (comment).

Which issue(s) this PR fixes:
Part of #6529

Release note:

NONE

@gardener-prow gardener-prow bot added area/high-availability High availability related kind/enhancement Enhancement, improvement, extension labels Sep 23, 2022
@gardener-prow gardener-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Sep 23, 2022
@rfranzke
Copy link
Member

/assign @timuthy @unmarshall

timuthy
timuthy requested changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the improvements. Just two suggestions from my side.

docs/proposals/20-ha-control-planes.md Outdated Show resolved Hide resolved
docs/proposals/20-ha-control-planes.md Outdated Show resolved Hide resolved
@ialidzhikov ialidzhikov force-pushed the fix/gep-20 branch 2 times, most recently from 07d8521 to 9c6b24f Compare October 3, 2022 06:16
@rfranzke rfranzke requested a review from timuthy October 4, 2022 07:41
@rfranzke
Copy link
Member

rfranzke commented Oct 7, 2022

@timuthy Can we merge this?

timuthy
timuthy requested changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more points I noticed after the changes.

docs/proposals/20-ha-control-planes.md Outdated Show resolved Hide resolved
docs/proposals/20-ha-control-planes.md Outdated Show resolved Hide resolved
@ialidzhikov ialidzhikov force-pushed the fix/gep-20 branch 3 times, most recently from b2a0538 to b699a3f Compare October 10, 2022 10:55
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 14, 2022

@ialidzhikov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dependency-watchdog-verify-image-build b699a3f link true /test pull-dependency-watchdog-verify-image-build

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ialidzhikov ialidzhikov force-pushed the fix/gep-20 branch 3 times, most recently from d00cebe to 80c42e2 Compare October 20, 2022 08:41
timuthy
timuthy reviewed Oct 21, 2022
View reviewed changes
Copy link
Contributor

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for all the efforts and clarification about this topic @ialidzhikov and @himanshu-kun ❤️
/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2022
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2022
timuthy
timuthy reviewed Oct 21, 2022
View reviewed changes
Copy link
Contributor

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2022
@timuthy
Copy link
Contributor

timuthy commented Oct 24, 2022

/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timuthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@gardener-prow gardener-prow bot merged commit d550fd0 into gardener:master Oct 24, 2022
@ialidzhikov ialidzhikov deleted the fix/gep-20 branch November 12, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timuthy timuthy timuthy requested changes

@himanshu-kun himanshu-kun himanshu-kun left review comments

@acumino acumino Awaiting requested review from acumino

@rfranzke rfranzke Awaiting requested review from rfranzke

Assignees

@unmarshall unmarshall

@timuthy timuthy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/high-availability High availability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ialidzhikov @rfranzke @timuthy @himanshu-kun @unmarshall