Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in number of tasks in Splitters.rst #2298

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

dg1223
Copy link
Contributor

@dg1223 dg1223 commented Feb 26, 2024

In the documentation page for Splitters, it is mentioned that the prime factorisation job for a very large number is being split into 5 different tasks whereas the code for job declation actually splits it up into 10 subjobs:

We can split up the factorisation of a very large number up into 5 different tasks.
splitter = PrimeFactorizerSplitter(numsubjobs=10))

This PR fixes the typo to resolve the discrepancy in the documentation.

@dg1223 dg1223 temporarily deployed to Integrate Pull Request February 26, 2024 03:31 — with GitHub Actions Inactive
@dg1223
Copy link
Contributor Author

dg1223 commented Feb 26, 2024

Just wanted to add that I ran tests (python -m pytest ganga/GangaCore/test/Unit) after making the change and they all passed as expected since this is just a documentation fix.

@egede egede self-requested a review February 26, 2024 05:53
Copy link
Member

@egede egede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@mesmith75 mesmith75 temporarily deployed to Integrate Pull Request February 26, 2024 09:48 — with GitHub Actions Inactive
@mesmith75 mesmith75 merged commit 73caa96 into ganga-devs:develop Feb 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants