Avoid reading configuration file multiple times #2139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The load_config_files function of GangaCore Config init would read system config variables in a loop, and set session variables in each loop cycle. This would cause the config file to be read multiple times. This commit moves the reading of user config and setting of session variables outside the loop. Signed-off-by: Vedansh Bhartia <vedanshbhartia@gmail.com>
mesmith75
approved these changes
Mar 23, 2023
alexanderrichards
approved these changes
Mar 23, 2023
egede
changed the title
egede
changed the title
|
@vedanshbhartia Thanks for fixig this problem. I have created a clone that will be merged (to work around the CI from forks problem). This PR will be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The load_config_files function of GangaCore Config init would read system config variables in a loop, and set session variables in each loop cycle. This would cause the config file to be read multiple times. This commit moves the reading of user config and setting of session variables outside the loop.