Remove environment mangling #2132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mesmith75
changed the title
mesmith75
changed the title
alexanderrichards
previously approved these changes
Mar 16, 2023
There was a problem hiding this comment.
This is interesting as on the face of it we seem to simply be copying the os.environ so I wouldn't have expected any difference between this and the new code where we use the os.environ directly. I imagine the reason this was do was to create a copy of the environment to avoid polluting it.
| execute('source {0} {1}'.format(setup, " ".join(setup_args)), shell=True, env=self.env, update_env=True) | ||
|
|
||
| else: | ||
| # bug #44334: Ganga/Utility/Shell.py does not save environ |
There was a problem hiding this comment.
I assume that the bug #44334 is a reference to something very old that we don't care about.
egede
reviewed
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2104
We should leave the environments as
os._Environobjects. It stop the mangling of the environment that causes #2104