Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cleanup) Members card conf : adaptive size #484

Merged
merged 1 commit into from May 4, 2024
Merged

Conversation

trasher
Copy link
Member

@trasher trasher commented Apr 10, 2024

No description provided.

@trasher trasher force-pushed the feature/cards-sizes branch 4 times, most recently from 592affd to e90ff8f Compare April 10, 2024 06:48
@trasher trasher force-pushed the feature/cards-sizes branch 2 times, most recently from ec55d1c to 922b186 Compare April 18, 2024 08:21
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

Attention: Patch coverage is 68.57143% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 48.16%. Comparing base (d92a909) to head (eb4ae6b).

Files Patch % Lines
galette/lib/Galette/Controllers/AuthController.php 0.00% 15 Missing ⚠️
galette/lib/Galette/IO/PdfMembersCards.php 87.80% 5 Missing ⚠️
galette/lib/Galette/Core/Preferences.php 85.71% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #484      +/-   ##
=============================================
+ Coverage      48.14%   48.16%   +0.01%     
- Complexity      6317     6321       +4     
=============================================
  Files            158      158              
  Lines          23790    23808      +18     
=============================================
+ Hits           11454    11466      +12     
- Misses         12336    12342       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trasher trasher marked this pull request as ready for review May 3, 2024 13:16
@trasher trasher merged commit eb4ae6b into develop May 4, 2024
35 checks passed
@trasher trasher deleted the feature/cards-sizes branch May 4, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants