Fix histroy filter

galette · May 10, 2024 · 7013f71 · 7013f71
1 parent 4e6d1c2
commit 7013f71
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/galette/lib/Galette/Core/History.php b/galette/lib/Galette/Core/History.php
@@ -212,6 +212,7 @@ public function getHistory(): array
      */
     private function buildLists(Select $select): void
     {
+        $this->users = [];
         try {
             $usersSelect = clone $select;
             $usersSelect->reset($usersSelect::COLUMNS);
@@ -312,8 +313,7 @@ private function buildWhereClause(Select $select): void
                 );
             }
 
-            //@phpstan-ignore-next-line
-            if ($this->filters->user_filter != null) {
+            if ($this->filters->user_filter !== null && $this->filters->user_filter != '0') {
                 if ($this->filters->user_filter === _T('None')) {
                     $this->filters->user_filter = '';
                 }
@@ -323,8 +323,7 @@ private function buildWhereClause(Select $select): void
                 );
             }
 
-            //@phpstan-ignore-next-line
-            if ($this->filters->action_filter != null && $this->filters->action_filter != '0') {
+            if ($this->filters->action_filter !== null && $this->filters->action_filter != '0') {
                 $select->where->equalTo(
                     'action_log',
                     $this->filters->action_filter