Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tools/hybpiper from version 2.1.6 to 2.1.7 #6002

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gxydevbot
Copy link
Collaborator

Hello! This is an automated update of the following tool: tools/hybpiper. I created this PR because I think the tool's main dependency is out of date, i.e. there is a newer version available through conda.

I have updated tools/hybpiper from version 2.1.6 to 2.1.7.

Project home page: https://github.com/mossmatters/HybPiper/releases

For any comments, queries or criticism about the bot, not related to the tool being updated in this PR, please create an issue here.

@SaimMomin12
Copy link
Contributor

SaimMomin12 commented May 16, 2024

Planemo lint throws below error. @TomHarrop do you have some inputs regarding this issue?

.. ERROR: Invalid XML found in file: hybpiper.xml. Errors [/tmp/tmpc4miyw96:199:0:ERROR:SCHEMASV:SCHEMAV_ELEMENT_CONTENT: Element 'actions': This element is not expected. Expected is one of ( data, discover_datasets, filter ).
/tmp/tmpc4miyw96:204:0:ERROR:SCHEMASV:SCHEMAV_ELEMENT_CONTENT: Element 'actions': This element is not expected. Expected is one of ( data, discover_datasets, filter ).]

@bgruening
Copy link
Member

Maybe that is a false positive? @bernt-matthias what do you think?

@TomHarrop
Copy link
Contributor

The wrapper has two action directives. The only thing I can see is that they are under collection > data tag sets rather than plain data.

They are just for the column names so we could remove them?

@bgruening
Copy link
Member

@TomHarrop can you test if the action works, if the columns names are changed. If so we need to extend the schema.xsd

@TomHarrop
Copy link
Contributor

@bgruening The current action works and the column names haven't been changed in this version.

Or did you want me to try manually changing the names in the output and seeing if the action works? Sorry if I misunderstood 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants