Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce slightly scanpy tools profile for wider instance support #6001

Merged
merged 5 commits into from
May 18, 2024

Conversation

pcm32
Copy link
Member

@pcm32 pcm32 commented May 11, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

The IUC Scanpy tools are using a profile version that doesn't allow us to install them alongside our tools on some private instances that we have. I noticed that the current profile had a value outside of the described ones on the tools XML docs, so I have nudged the value to the closest lower one.

This doesn't have any impact on tools really, mostly on where they can be installed, but let me know if this merits a galaxy+<num> version bump on tools. I hope that this change is acceptable.

@pcm32
Copy link
Member Author

pcm32 commented May 11, 2024

Would it be possible to waive the old/broken URLs updates? This makes updating any old tool (and not so old by the looks of it) very laborious :-(.

@pcm32 pcm32 closed this May 14, 2024
@pcm32 pcm32 reopened this May 14, 2024
@pavanvidem
Copy link
Member

@pcm32
Copy link
Member Author

pcm32 commented May 15, 2024

That didn't cut it :-(...

@pcm32
Copy link
Member Author

pcm32 commented May 15, 2024

So it is a matter of chasing link by link, which is really a lot of time (I tried a few easy iterations on the current ones without success).... I would just remove them, people if needed can always search for scanpy's documentation and find the current one (actually the tool points to a different version of the documentation that it should, so it is not completely correct from purist point of view, but chasing that is a lot of energy). Or suggest the change in the linter to waive broken URLs if possible.

Copy link
Member

@pavanvidem pavanvidem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the the whole toolsuite soon. Then we will remove them. This time please accept my suggestions. Hopefully, that fixes.

tools/scanpy/plot.xml Outdated Show resolved Hide resolved
tools/scanpy/plot.xml Outdated Show resolved Hide resolved
tools/scanpy/plot.xml Outdated Show resolved Hide resolved
tools/scanpy/plot.xml Outdated Show resolved Hide resolved
tools/scanpy/plot.xml Outdated Show resolved Hide resolved
tools/scanpy/remove_confounders.xml Outdated Show resolved Hide resolved
tools/scanpy/normalize.xml Outdated Show resolved Hide resolved
tools/scanpy/normalize.xml Outdated Show resolved Hide resolved
tools/scanpy/normalize.xml Outdated Show resolved Hide resolved
tools/scanpy/inspect.xml Outdated Show resolved Hide resolved
@pavanvidem
Copy link
Member

Maybe the galaxy version should be bumped now

Co-authored-by: Pavankumar Videm <pavanvidem@gmail.com>
@pcm32
Copy link
Member Author

pcm32 commented May 15, 2024

Maybe the galaxy version should be bumped now

Why? this is what I'm trying to avoid actually. Or I'm misunderstanding what you mean.

@pcm32
Copy link
Member Author

pcm32 commented May 15, 2024

Unless that the tools really require profile increases for newer functionality, the only thing it does is that it makes tools uninstallable in older instances AFAIK, reducing the potential impact of the tools.

@pcm32
Copy link
Member Author

pcm32 commented May 15, 2024

Apparently those changes did it, thanks @pavanvidem !

Copy link
Member

@pavanvidem pavanvidem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether changing the help is considered a wrapper update or not. Fine for me to approve as it is now.

@pcm32
Copy link
Member Author

pcm32 commented May 15, 2024

Ahh, you meant the +galaxy<num>, yes maybe we should. Tricky, not sure. The tools themselves are unchanged.

@pavanvidem
Copy link
Member

pavanvidem commented May 15, 2024

Yes, I meant the version suffix. Let's see what others say.

@pavanvidem
Copy link
Member

@pcm32 can you please bump the version suffix and then we are hopefully good to go

@bgruening
Copy link
Member

Thanks @pcm32

@bgruening bgruening merged commit 9d49b2a into galaxyproject:main May 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants