-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce slightly scanpy tools profile for wider instance support #6001
Conversation
Would it be possible to waive the old/broken URLs updates? This makes updating any old tool (and not so old by the looks of it) very laborious :-(. |
how about changing all the links to https://scanpy.readthedocs.io? For eg. https://scanpy.readthedocs.io/en/stable/api/generated/scanpy.pp.neighbors.html works |
That didn't cut it :-(... |
So it is a matter of chasing link by link, which is really a lot of time (I tried a few easy iterations on the current ones without success).... I would just remove them, people if needed can always search for scanpy's documentation and find the current one (actually the tool points to a different version of the documentation that it should, so it is not completely correct from purist point of view, but chasing that is a lot of energy). Or suggest the change in the linter to waive broken URLs if possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update the the whole toolsuite soon. Then we will remove them. This time please accept my suggestions. Hopefully, that fixes.
Maybe the galaxy version should be bumped now |
Co-authored-by: Pavankumar Videm <pavanvidem@gmail.com>
Why? this is what I'm trying to avoid actually. Or I'm misunderstanding what you mean. |
Unless that the tools really require profile increases for newer functionality, the only thing it does is that it makes tools uninstallable in older instances AFAIK, reducing the potential impact of the tools. |
Apparently those changes did it, thanks @pavanvidem ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether changing the help is considered a wrapper update or not. Fine for me to approve as it is now.
Ahh, you meant the |
Yes, I meant the version suffix. Let's see what others say. |
@pcm32 can you please bump the version suffix and then we are hopefully good to go |
Thanks @pcm32 |
FOR CONTRIBUTOR:
The IUC Scanpy tools are using a profile version that doesn't allow us to install them alongside our tools on some private instances that we have. I noticed that the current profile had a value outside of the described ones on the tools XML docs, so I have nudged the value to the closest lower one.
This doesn't have any impact on tools really, mostly on where they can be installed, but let me know if this merits a
galaxy+<num>
version bump on tools. I hope that this change is acceptable.