Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COSG #5959

Merged
merged 24 commits into from
May 29, 2024
Merged

COSG #5959

merged 24 commits into from
May 29, 2024

Conversation

heylf
Copy link
Contributor

@heylf heylf commented Apr 19, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@heylf
Copy link
Contributor Author

heylf commented Apr 19, 2024

This implement a tool for marker gene detection: https://github.com/genecell/COSG.

I used test data from the scanpy suite.

Please do not merge yet, because I check with single cell community to implement a marker gene filtering.

tools/cosg/macros.xml Outdated Show resolved Hide resolved
tools/cosg/cosg.xml Outdated Show resolved Hide resolved
tools/cosg/cosg.xml Outdated Show resolved Hide resolved
tools/cosg/cosg.xml Outdated Show resolved Hide resolved
tools/cosg/cosg.xml Outdated Show resolved Hide resolved
tools/cosg/cosg.xml Outdated Show resolved Hide resolved
tools/cosg/cosg.xml Outdated Show resolved Hide resolved
tools/cosg/cosg.xml Outdated Show resolved Hide resolved
tools/cosg/cosg.xml Outdated Show resolved Hide resolved
heylf and others added 8 commits May 3, 2024 13:52
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
@bgruening
Copy link
Member

@heylf do you need help here? There are some linting issues.

@heylf
Copy link
Contributor Author

heylf commented May 6, 2024

@bgruening no its fine I already found it. Was a silly mistake.

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to reduce the size of the test data? Could the output h5ad be replaced by some assertions or just removed?

tools/cosg/cosg.xml Outdated Show resolved Hide resolved
tools/cosg/cosg.xml Outdated Show resolved Hide resolved
tools/cosg/cosg.xml Outdated Show resolved Hide resolved
tools/cosg/cosg.xml Show resolved Hide resolved
tools/cosg/macros.xml Outdated Show resolved Hide resolved
@heylf
Copy link
Contributor Author

heylf commented May 28, 2024

Is it possible to reduce the size of the test data? Could the output h5ad be replaced by some assertions or just removed?

data reduced in size now

tools/cosg/macros.xml Outdated Show resolved Hide resolved
tools/cosg/macros.xml Outdated Show resolved Hide resolved
tools/cosg/cosg.xml Outdated Show resolved Hide resolved
tools/cosg/cosg.xml Outdated Show resolved Hide resolved
@bgruening bgruening merged commit 2e477de into galaxyproject:main May 29, 2024
11 checks passed
@bgruening
Copy link
Member

Thanks @heylf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants