Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Anndata Ops #5957

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add Anndata Ops #5957

wants to merge 4 commits into from

Conversation

mtekman
Copy link
Contributor

@mtekman mtekman commented Apr 18, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

This tool brings AnnData Operations under the AnnData suite

</description>
<macros/>
<requirements>
<requirement type="package" version="0.10.7">anndata</requirement>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to have the same version of the requirements as the other tools. Maybe update this in the macros.xml and import macros.xml here.

</when>
<when value="false"></when>
</conditional>
<param name="copy_adata_to_raw" type="boolean" label="Copy AnnData to .raw" help="If activated, it will do 'adata.raw = adata'" checked="false"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This operation already exist in the manipulate tool. Please check if there other repeated operations. Let's keep only one of them.

@pcm32
Copy link
Member

pcm32 commented May 1, 2024

Hi guys, can I ask why is this added here instead of making changes on the EBI repo? This will lead to tool duplication and confusion, because already many instances use these tools.

@pcm32
Copy link
Member

pcm32 commented May 1, 2024

AnnData ops as part of EBI tools has been updated to newer AnnData for a good while now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants