Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idr_download bug fixes #5931

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sunyi000
Copy link
Contributor

@sunyi000 sunyi000 commented Apr 5, 2024

FOR CONTRIBUTOR:

  • [x ] I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • [x ] License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • [x ] This PR updates an existing tool or tool collection
  • This PR does something else (explain below)
  • increase the pylibtiff version to fix some bugs.
  • fix xml linting warnings
  • increase the galaxy profile version

@bgruening could you please have a look at this? thank you

@sunyi000 sunyi000 changed the title increase tifffile version to fix bug, bump up profile version idr_download bug fixes Apr 5, 2024
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good, but tests are failing.

@@ -1,5 +1,5 @@
<?xml version="1.0"?>
<tool id="idr_download_by_ids" name="Download IDR/OMERO" version="0.44.1" profile="18.09">
<tool id="idr_download_by_ids" name="Download IDR/OMERO" version="0.44.2" profile="24.0">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The profile version is very recent, you will exclude a few galaxy servers that have not been updated in the last days. 23.0 or 23.1 should be ok.

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it known why the collection element names changed?

@sunyi000
Copy link
Contributor Author

sunyi000 commented Apr 5, 2024

Is it known why the collection element names changed?

I didn't change the names, but the orders. The planemo test is complaining about output order is wrong, so I moved the first element to the last.

@sunyi000
Copy link
Contributor Author

sunyi000 commented Apr 5, 2024

I got confused a bit.

with conda resolution
planemo test . give successful results
without conda resolution
planemo test --biocontainers . give failed test results

how should I solve this? Thanks

@bgruening
Copy link
Member

Maybe a dependency is missing? Container tests are more strict and maybe it complains about a missing dependency ?

@sunyi000
Copy link
Contributor Author

sunyi000 commented Apr 5, 2024

Maybe a dependency is missing? Container tests are more strict and maybe it complains about a missing dependency ?

yes, it complains about libtiff no module found, which is part of the pylibtiff package already specified in the requirements

@sunyi000
Copy link
Contributor Author

sunyi000 commented Apr 5, 2024

I found these:

with planemo test --biocontainers . pylibtiff has to be version 0.4.2 for the tests to pass, other versions will fail.

with planemo test . the latest pylibtiff==0.6.1and v0.5.1 will pass, but 0.4.2 fails

and the current tool idr_download in Galaxy did not work..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants