-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
idr_download bug fixes #5931
base: main
Are you sure you want to change the base?
idr_download bug fixes #5931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks good, but tests are failing.
@@ -1,5 +1,5 @@ | |||
<?xml version="1.0"?> | |||
<tool id="idr_download_by_ids" name="Download IDR/OMERO" version="0.44.1" profile="18.09"> | |||
<tool id="idr_download_by_ids" name="Download IDR/OMERO" version="0.44.2" profile="24.0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The profile version is very recent, you will exclude a few galaxy servers that have not been updated in the last days. 23.0 or 23.1 should be ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it known why the collection element names changed?
I didn't change the names, but the orders. The planemo test is complaining about output order is wrong, so I moved the first element to the last. |
I got confused a bit. with conda resolution how should I solve this? Thanks |
Maybe a dependency is missing? Container tests are more strict and maybe it complains about a missing dependency ? |
yes, it complains about |
I found these: with with and the current tool idr_download in Galaxy did not work.. |
FOR CONTRIBUTOR:
@bgruening could you please have a look at this? thank you