dada2 use default_identifier_source #5896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do we test this? |
|
Can only be tested manually as far as I know - is this true @mvdbeek? |
|
yes |
such that at least containers are used
bgruening
approved these changes
Mar 23, 2024
|
I'm just testing this. |
|
Works. But apparently also worked before? Seems that I still have not understood the problem completely. Regarding the PR I would say that it does not hurt and fixes a few minor problems, e.g. I bumped the DM profile such that containers are used (pre 18.09 containers are not used). |
|
Thank you @bernt-matthias! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FOR CONTRIBUTOR: