Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python version option to planemo test command #2485

Closed
wants to merge 56 commits into from

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Jul 7, 2019

Also, change python version to 3.6.

This is the first step in ref to:
#2168

Ping @mvdbeek

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

wm75 and others added 30 commits April 5, 2019 17:34
This changeset:
- upgrades the STAR tool and the associated data manager to the latest version of STAR
- restructures the tool interface in an attempt to present important parameters first
- introduces a new versioned index data table, which is used to offer only version-compatible
  indexes in the tool interface
- adds the necessary files for testing the use of cached indexes

STARsolo parameters will have to be added separately, or be introduced through a dedicated tool.
Also fixes setting metadata on output datasets and edge cases with
enabling/disabling chimeric alignments.
For readability, also start distinguishing between with-gtf and
with-gene-model parameters and variables.
Flattens the algorithmic parameter section partially, documents
the exact recommendations for using the tool upstream of
STAR-Fusion, and switches the default for unmapped reads to be
retained in the BAM output (since that's the setting recommended
for STAR-Fusion, and because they are easy to eliminate, but
impossible to add later.
Bandage: add parameters to add name and length labels to nodes
jdavcs and others added 3 commits July 7, 2019 17:02
Expect to fail: bowtie2 won't run under python3. Fix to be added in
subsequent commit.
@nsoranzo
Copy link
Member

nsoranzo commented Jul 8, 2019

Travis fails at the lint stage (i.e. before actual testing) because several Python files are not Python3-compatible.
You can fix them with the process described in galaxyproject/galaxy#1715 .

@jdavcs
Copy link
Member Author

jdavcs commented Jul 8, 2019

@nsoranzo got it! (i saw it failed as expected, but for the wrong reason). I'll get to this later today.

@nsoranzo
Copy link
Member

Can you please rebase the pull request? Unfortunately we had to do a force-push on the master branch.

Please let us know if you have issues and we can do it for you.

@jdavcs
Copy link
Member Author

jdavcs commented Jul 18, 2019

@nsoranzo yep, i'm on it.

Also, change python version to 3.6.

This is the first step in ref to:
galaxyproject#2168
Expect to fail: bowtie2 won't run under python3. Fix to be added in
subsequent commit.
Done mostly using 2to3 with manual sanity checks.
Add `from __future__ import print_function` where converting
print to print().

This only covers files that had linting errors.
@jdavcs
Copy link
Member Author

jdavcs commented Jul 19, 2019

This has been replaced by #2493

@jdavcs jdavcs closed this Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet