Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign image tag based on the pulsar wheel version #183

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VJalili
Copy link
Member

@VJalili VJalili commented May 15, 2019

It can help find a docker image if its tag is set appropriately, e.g., using the version of pulsar wheel used for creating the image.

On my mac I am not able to leverage BASH_REMATCH[1] to extract version number from the wheel filename, since it seems macOS has a different function that overrides the value of this variable: https://stackoverflow.com/a/40457982

Creating draft PR, in case anyone interested and know a workaround.

Alternatively, we might be able to use a method similar to the following:

pulsar/setup.py

Lines 46 to 50 in ddf2fde

_version_re = re.compile(r'__version__\s+=\s+(.*)')
with open('pulsar/__init__.py', 'rb') as f:
version = str(ast.literal_eval(_version_re.search(
f.read().decode('utf-8')).group(1)))

It can help find a docker image if its tag is set appropriately, e.g., using the version of pulsar wheel used for creating the image. 

On my mac I am not able to leverage `BASH_REMATCH[1]` to extract version number from the wheel filename, since it seems macOS has a different function that overrides the value of this variable: https://stackoverflow.com/a/40457982
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant