Make Toolshed Python 3 compatible & tests #9528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
added
kind/bug
kind/refactoring
nsoranzo
reviewed
Mar 17, 2020
lib/galaxy/dependencies/pipfiles/default/pinned-dev-requirements.txt
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
mvdbeek
force-pushed
the
twill_work
branch
3 times, most recently
from
2c594c9
to
9751b99
Compare
|
Alright, after b2850ea which fixes a silly bug I introduced the tests are passing with upstream twill. So I guess this is ready to be reviewed. |
|
Unfortunately this needs a rebase now. |
jdavcs
requested changes
Apr 3, 2020
jdavcs
approved these changes
Apr 3, 2020
nsoranzo
reviewed
Apr 11, 2020
nsoranzo
reviewed
Apr 12, 2020
|
I've rebased the PR, condensing the changes to |
mvdbeek
commented
Apr 12, 2020
lib/galaxy/tool_shed/galaxy_install/tool_dependencies/recipe/install_environment.py
Show resolved
Hide resolved
nsoranzo
approved these changes
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardest part was to fix twill. My fork now passes all tests (https://github.com/mvdbeek/twill3), and I think they had been broken for many years.
Most of the Galaxy / Toolshed changes are standard bytestring / unicode issues. In particular mercurial functions expect bytestring input and return bytestrings as output.
Also moves the toolshed tests to github CI.
Close #1715 .