-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid so much duplicate code #895
base: main
Are you sure you want to change the base?
Avoid so much duplicate code #895
Conversation
Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
connection.addRequestProperty("zos3270-runid", this.runId); | ||
connection.addRequestProperty("zos3270-terminalid", this.terminalId); | ||
connection.addRequestProperty("zos3270-runid", runId); | ||
connection.addRequestProperty("zos3270-terminalid", terminalId); | ||
connection.setDoInput(true); | ||
connection.setDoOutput(false); | ||
connection.connect(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we are assuming that garbage collection of the connection will close the connection, and we don't have to do it explicitly ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we shouldnt. We should have the connection closed during provisionDiscard
Build successful |
1 similar comment
Build successful |
…3270-terminal-avoiding-duplicate-code
Build successful |
Signed-off-by: Mike Cobbett 77053+techcobweb@users.noreply.github.com