Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

creating auth tokens get command #241

Merged
merged 29 commits into from
May 24, 2024
Merged

creating auth tokens get command #241

merged 29 commits into from
May 24, 2024

Conversation

Akyiaa
Copy link
Contributor

@Akyiaa Akyiaa commented May 17, 2024

@Akyiaa
created an auth tokens get command
703b17b 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@Akyiaa
created auth tokens and auth tokens get command with unit tests
178f46e 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@Akyiaa
more functionality for GetTokens and format types
77435d6 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@Akyiaa
fixed compilation error
84c74a1 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@Akyiaa
added bootstrap flag for auth tokens cmds
2e7c25d 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@Akyiaa
correct formatting for dates
d39c030 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@Akyiaa
testing for auth tokens get
6916caa 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@Akyiaa
updated summaryFormatter retrieved values
2807042 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@Akyiaa
cleaned up code to only have summary formatter
1190e5f 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-241-rx9lm for details. If you are unable to do so, please contact a member of the Galasa team.

@Akyiaa
updated the docs
5a1869d 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@Akyiaa
updated makefile
ff0abd4 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-241-l5pgz for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-241-4fxmz for details. If you are unable to do so, please contact a member of the Galasa team.

@Akyiaa
empty commit to build
ea9d44a 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@Akyiaa
cleaning code
e20f9d5 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@Akyiaa
empty commit to build
b04e37d 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-241-c6929 for details. If you are unable to do so, please contact a member of the Galasa team.

@Akyiaa
changing makefile
17acf0c 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-241-dl22w for details. If you are unable to do so, please contact a member of the Galasa team.

@Akyiaa
updated makefile
99c9d1f 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-241-l47j5 for details. If you are unable to do so, please contact a member of the Galasa team.

@Akyiaa
updated makefile
efbbf1b 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-241-98v2g for details. If you are unable to do so, please contact a member of the Galasa team.

@Akyiaa
update makefile to find error point
b71a6c6 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-241-lfvdx for details. If you are unable to do so, please contact a member of the Galasa team.

@Akyiaa
updated makefile
94cf429 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-241-fvmjc for details. If you are unable to do so, please contact a member of the Galasa team.

@Akyiaa Akyiaa linked an issue May 21, 2024 that may be closed by this pull request
CLI: User can list the access tokens in the system galasa-dev/projectmanagement#1805
Closed
18 tasks
@Akyiaa
updated the makefile
b9481d2 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-241-ckq6l for details. If you are unable to do so, please contact a member of the Galasa team.

@Akyiaa
updated alias for auth tokens cmd
4c96cff 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-241-slrwx for details. If you are unable to do so, please contact a member of the Galasa team.

@Akyiaa
empty commit to build
831ff34 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-241-728zn for details. If you are unable to do so, please contact a member of the Galasa team.

@Akyiaa
merge main into branch
0bcd8f4 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-241-267bm for details. If you are unable to do so, please contact a member of the Galasa team.

@Akyiaa
empty commit to build
e66b032 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-241-fddb5 for details. If you are unable to do so, please contact a member of the Galasa team.

@Akyiaa
updated creation time display
134b45a 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-241-nfqt2 for details. If you are unable to do so, please contact a member of the Galasa team.

@Akyiaa
empty commit to build
a3a5b5e 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build successful

@Akyiaa Akyiaa requested a review from eamansour May 24, 2024 08:44
eamansour
eamansour requested changes May 24, 2024
View reviewed changes
Copy link
Member

@eamansour eamansour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! Just spotted a few changes worth making before merging this, let me know if anything doesn't make sense!

README.md Outdated Show resolved Hide resolved
docs/generated/galasactl_auth_get.md Outdated Show resolved Hide resolved
pkg/auth/authTokensGet_test.go Outdated Show resolved Hide resolved
pkg/auth/authTokensGet_test.go Show resolved Hide resolved
pkg/auth/authTokensGet.go Outdated Show resolved Hide resolved
pkg/cmd/authTokens.go Outdated Show resolved Hide resolved
pkg/cmd/authTokensGet_test.go Show resolved Hide resolved
pkg/cmd/authTokens_test.go Outdated Show resolved Hide resolved
pkg/errors/errorMessage.go Outdated Show resolved Hide resolved
@Akyiaa
changes based on pr comments
5ca9746 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build successful

eamansour
eamansour requested changes May 24, 2024
View reviewed changes
pkg/auth/authTokensGet.go Outdated Show resolved Hide resolved
@Akyiaa
error handling for retrieving tokens from rest api
46a602c 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@Akyiaa
cleaned code
79ae5fc 
Signed-off-by: Fiona Ampofo <64271621+Akyiaa@users.noreply.github.com>
@galasa-team
Copy link

Build successful

@Akyiaa Akyiaa requested a review from eamansour May 24, 2024 13:12
@galasa-team
Copy link

Build successful

@Akyiaa Akyiaa merged commit 96208b9 into main May 24, 2024
5 checks passed
@Akyiaa Akyiaa deleted the iss1805-list-tokens branch May 24, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamansour eamansour eamansour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Akyiaa @galasa-team @eamansour