Don't error with zero length elem in add_to_last #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following expression from **Rmpi** raises an error due to `breaks_tail` seeing a zero length breaks.
```{r}
function (dellog = TRUE, comm = 1) {
if (mpi.comm.size(comm) < 2) {
err <- paste("It seems no slaves running on comm", comm)
stop(err)
}
mpi.bcast.cmd(cmd = break, rank = 0, comm = comm)
if (.Platform$OS != "windows") {
if (dellog && mpi.comm.size(0) < mpi.comm.size(comm)) {
tmp <- paste(Sys.getpid(), "+", comm, sep = "")
logfile <- paste("*.", tmp, ".*.log", sep = "")
if (length(system(paste("ls", logfile), TRUE, ignore.stderr = TRUE)) >=
1)
system(paste("rm", logfile))
}
}
if (comm > 0) {
if (is.loaded("mpi_comm_disconnect"))
mpi.comm.disconnect(comm)
else mpi.comm.free(comm)
}
}
```
gaborcsardi
changed the title
|
Hmmm, if this happens because of a bug in cyclocomp, then we could fix the bug, I guess. FWIW there is no error on Rmpi currently, so I am going to close this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. MangoTheCat#17
The following expression from Rmpi raises an error due to
breaks_tailseeing a zero length breaks.