Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add addToBatch and batchSpend methods and types #25

Open
wants to merge 27 commits into
base: dev
Choose a base branch
from
Open

Add addToBatch and batchSpend methods and types #25

wants to merge 27 commits into from

Conversation

xsats
Copy link

@xsats xsats commented Nov 10, 2020

No description provided.

@gabidi gabidi changed the base branch from master to dev November 10, 2020 13:59
gabidi
gabidi reviewed Nov 10, 2020
View reviewed changes
Copy link
Owner

@gabidi gabidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR 👍
Can I please ask you to update the btcClient tests with the new functionality ?
Besides ensuring everything works, it acts as documentation (for now) for devs on how to use this lib.
Thanks again!

@xsats
Copy link
Author

xsats commented Nov 11, 2020

No problem!
I'm not running a testnet cyphernode at the moment which makes running and properly testing the tests a bit tricky, unfortunately - otherwise I'd write them up immediately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabidi gabidi gabidi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xsats @gabidi @edmball