Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add emitter into SSR failed error #766

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[chore] add emitter into SSR failed error #766

wants to merge 2 commits into from

Conversation

ardok
Copy link
Contributor

@ardok ardok commented Jun 7, 2021

  • Need a way to piggy back the SSR error detection so that devs can do something when that happens, such as emitting m3.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Comment on lines +15 to +16
type ExtractReturnType = <V>(() => V) => V;
type IEmitter = $Call<ExtractReturnType, typeof UniversalEventsToken>;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just following from some other package. Looks like there is no UniversalEvents flow type exported from fusion-plugin-universal-events.

@ardok
Copy link
Contributor Author

ardok commented Jun 7, 2021

I don't know how to run jz install.

ardo@ardo-C02C8497MD6R fusionjs % jz install
Error: Your cwd /Users/ardo/Documents/workspace/fusionjs is not listed in manifest.json. If you are at the wrong directory, cd into your desired directory or use the --cwd flag. If you are in the desired directory, make sure it is listed in the projects field in manifest.json
    at validateRegistration (/private/var/tmp/_bazel_ardo/ae60a76a916af9dddaf5accdfb689080/external/jazelle/commands/install.js:72:11)
    at install (/private/var/tmp/_bazel_ardo/ae60a76a916af9dddaf5accdfb689080/external/jazelle/commands/install.js:44:3)
    at async cli (/private/var/tmp/_bazel_ardo/ae60a76a916af9dddaf5accdfb689080/external/jazelle/utils/cli.js:40:9)
    at async Object.runCLI (/private/var/tmp/_bazel_ardo/ae60a76a916af9dddaf5accdfb689080/external/jazelle/index.js:54:3)
ardo@ardo-C02C8497MD6R fusion-plugin-apollo % jz install
Error: ENOENT: no such file or directory, open '/Users/ardo/Documents/workspace/fusionjs/create-fusion-plugin/package.json'

@@ -13,7 +13,8 @@
"apollo-link-http": "^1.5.15",
"apollo-link-schema": "^1.2.3",
"apollo-server-koa": "^2.7.0",
"koa-compose": "^4.1.0"
"koa-compose": "^4.1.0",
"fusion-plugin-universal-events": "0.0.0-monorepo"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be declared as devDependencies + peerDependencies

@ardok
Copy link
Contributor Author

ardok commented Jun 8, 2021

Updated. But for the love of me, I still can't figure out how to run install....

image

And due to this, I cannot update yarn.lock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants