feat(fusion-cli): add graceful shutdown to start command #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheew
force-pushed
the
feat/graceful-shutdown
branch
from
44b1bf7
to
7693573
Compare
|
|
ganemone
previously approved these changes
Oct 20, 2020
lhorie
previously approved these changes
Oct 20, 2020
ganemone
approved these changes
Nov 12, 2020
lhorie
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to add signal handling to the
$ fusion startcommand. This solves 2 issues:fusion startcommand to not stop on SIGINT or SIGTERM. This will make sure fusion actually listens and respects these signals.fusion startwill gracefully exit and allows open connections to finish