Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to whitelist import paths for the translation babel plugin #756

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JPTeasdale
Copy link

This is in order to support custom typing of the useTranslations return function to enforce translation key validity:

IE:

import {useTranslations as useFusionTranslations} from 'fusion-plugin-i18n-react';
import type {TranslationKey} from './types/translation-types.js';
export const useTranslations: () => (
  key: TranslationKey,
  interpolations?: {+[string]: string | number}
) => string = useFusionTranslations;

This may be better accomplished with the ability to add a regex, but that would require a change to fusion-cli/build/babel-plugins/babel-plugin-utils/visit-named-module.js

@CLAassistant
Copy link

CLAassistant commented Jul 20, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


John Teasdale seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@JPTeasdale JPTeasdale changed the title Add option to whitelist import paths for the translation babel plugin. Add option to whitelist import paths for the translation babel plugin Jul 20, 2020
@shYkiSto shYkiSto added the WIP Work in progress label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants