Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-console eslint rule #731

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ericsoco
Copy link

@ericsoco ericsoco commented Feb 6, 2020

I imagine There Will Be Discussion about the value of adding / not adding this rule. IMO, it's a valuable safeguard against committing debugging statements, and is easy to disable line-by-line for necessary console usage.

(Note that no-console is not included in eslint:recommended.)

Also, it seems that eslint-config-uber-base might be a better place for this, but @rtsao suggested I start with a PR to Fusion.

@derekju derekju added the ci label Feb 6, 2020
@ericsoco
Copy link
Author

Any thoughts on adding this rule?

@CLAassistant
Copy link

CLAassistant commented Apr 17, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants