Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new edge to modern browsers #727

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DheerendraRathor
Copy link

Fixes #726

Since current edge is based on chromium, it should be listed in modern browsers. Also it is used as default browser by many developers.
Since version 79, it's based on Chromium.

@derekju derekju requested a review from rtsao January 30, 2020 18:51
@derekju derekju added the ci label Jan 30, 2020
chrisdothtml
chrisdothtml previously approved these changes Jan 30, 2020
@@ -11,4 +11,5 @@ module.exports = {
chrome: 61,
safari: 12,
firefox: 60,
edge: 79,
Copy link
Member

@rtsao rtsao Jan 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the babel env preset aware of chromium edge?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, babel env preset uses caniuse-lite which is aware of chromium edge.

@CLAassistant
Copy link

CLAassistant commented Apr 17, 2020

CLA assistant check
All committers have signed the CLA.

@DheerendraRathor
Copy link
Author

@chrisdothtml @rtsao Bump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modern browser versions should include chromium based edge
6 participants