This repository has been archived by the owner on May 17, 2019. It is now read-only.
Update history module lib def #251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method of importing createBrowserHistory with `import createBrowserHistory from 'history/createBrowserHistory'` causes warning messages during testing. The message produced below includes an example of how to import the `createBrowserHistory` function. This change updates the code to be compatible with the intent of the message.
```
console.error node_modules/history/warnAboutDeprecatedCJSRequire.js:17
Warning: Please use `require("history").createBrowserHistory` instead of `require("history/createBrowserHistory")`. Support for the latter will be removed in the next major release.
```
The import method for history required an update to v4.9.0.
Removed spaces.
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
=======================================
Coverage 79.81% 79.81%
=======================================
Files 10 10
Lines 218 218
Branches 48 48
=======================================
Hits 174 174
Misses 30 30
Partials 14 14
Continue to review full report at Codecov.
|
KevinGrandon
changed the title
angus-c
approved these changes
May 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing changes from #250 along with flow-typed/flow-typed#3306.