Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Add file list to package.json #739

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

madhusudhand
Copy link

fusion-cli npm modules includes all the files from source which makes it heavy.
Hence included only required files.

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2019

CLA assistant check
All committers have signed the CLA.

@madhusudhand madhusudhand changed the title Adding file list to package.json Add file list to package.json Mar 19, 2019
Copy link
Contributor

@KevinGrandon KevinGrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the contribution. I think this is very close to what we want to do. I think we do have a few deeply nested test folders currently that might need to be ignored, possibly with the ! operator.

Would you be up for trying to negate those here? Otherwise we would be happy to pick it up ourselves.

E.g., https://github.com/fusionjs/fusion-cli/tree/master/build/babel-plugins/babel-plugin-chunkid/test

@madhusudhand
Copy link
Author

@KevinGrandon added a generic negate rule "!**/test/" to ignore all the test directories under any directory not just 'build'. In case if we add test files for others later this will take care.

lhorie
lhorie previously approved these changes Mar 20, 2019
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Co-Authored-By: madhusudhand <madhusudhan.dollu@gmail.com>
Co-Authored-By: madhusudhand <madhusudhan.dollu@gmail.com>
@madhusudhand
Copy link
Author

Removed the optional entries README.md and LICENSE as per the review comments.

@rtsao
Copy link
Member

rtsao commented Apr 12, 2019

I think sw.js is also missing. This leaves me thinking maybe we might want to use .npmignore instead, which would be the contents of .gitignore plus:

docs/
test/e2e
.github/
.buildkite/
.*

I'm wary of accidentally having necessary files being published, so perhaps it's better to instead explicitly say which files should not be published.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants