Ensure storage objects are destroyed on application teardown in tests #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikek2252
changed the title
fsmanuel
approved these changes
Feb 4, 2024
addon/mixins/storage.js
Outdated
| @@ -86,6 +91,7 @@ export default Mixin.create({ | |||
| }, | |||
|
|
|||
| _save() { | |||
| if (this.isDestroying) return; | |||
There was a problem hiding this comment.
Suggested change
| if (this.isDestroying) return; | |
| if (this.isDestroying || this.isDestroyed) return; |
There was a problem hiding this comment.
Thanks updated the guard.
| @@ -43,7 +43,8 @@ | |||
| "ember-cli-babel": "^7.26.11", | |||
| "ember-cli-string-utils": "^1.1.0", | |||
| "ember-cli-version-checker": "^5.1.2", | |||
| "ember-copy": "^2.0.1" | |||
| "ember-copy": "^2.0.1", | |||
| "ember-destroyable-polyfill": "^2.0.3" | |||
fsmanuel
changed the title
|
@Mikek2252 released as v2.0.7. Thanks again for the fix! |
|
All of my tests are now failing because of this change. We have an instance-initializer that uses ember-local-storage and tries to update it and now it fails on every test saying something along the lines "..tried to set the property of a destroyed object" meaning the ember-local-storage is now destroyed when my instance-initializer tries to use it. |
|
@Pixelik oh no! Can you share the initializer? |
|
I will try to find some time and provide you with the code - for now I've downgraded it's ok 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #376
This is to ensure that storage objects are destroyed when the app is torn down in tests, currently objects created by
storageForare not destroyed after the test is torn down, i think this is because the class is returned by a computed property so is not destroyed by the parent that callsstorageForStorage instances of adapters are destroyed but i have added owner injection to ensure that
associateDestroyableChilddoes not error with a missing owner.to ensure backward compatibility i have also added the destroyable polyfill