chore: support ast-reflection s-expressions #520
Conversation
✅ Deploy Preview for effortless-malabi-1c3e77 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| throw new SynthError( | ||
| ErrorCodes.Unexpected_Error, | ||
| "Compilation Error: found an invalid register command. Check the versions of AST-Reflection and Functionless." | ||
| ); |
There was a problem hiding this comment.
Why not just make it a no-op?
There was a problem hiding this comment.
My thought was: The user wouldn't know it is an issue until runtime. If we cannot re-construct the command then we should fail.
There was a problem hiding this comment.
But how do you know it's not just someone else using similar looking syntax? The compiler should not produce an invalid contract right?
There was a problem hiding this comment.
We check for our flag on the left first. The chance someone has stash_salt=bind is very low.
That leaves all parsing errors as a bug or mis-matched package version ( with breaking changes)
Signed-off-by: github-actions <github-actions@github.com>
| minify: true, | ||
| minify: false, |
There was a problem hiding this comment.
Did you mean to check this in? It can cause problems?
| sourceMaps: "inline", | ||
| inlineSourcesContent: false, |
There was a problem hiding this comment.
I think this has an impact where identifiers that have been renamed cannot be re-mapped.
Required for: functionless/ast-reflection#32
Maintains backwards compatibility with previous register and bind functions.
AST-Reflection is changing from register and bind methods to using s-expression like sequence expressions.