This repository has been archived by the owner on Jun 9, 2020. It is now read-only.
Add cats.functor.Invariant instance for fs2.async.mutable.Queue #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,6 +20,20 @@ trait Instances extends Instances0 { | |||
| implicit def uf1ToNatrualTransformation[F[_], G[_]](implicit uf1: UF1[F, G]): NaturalTransformation[F, G] = new NaturalTransformation[F, G] { | |||
| def apply[A](fa: F[A]) = uf1(fa) | |||
| } | |||
|
|
|||
| implicit def catsInvariantQueue[F[_]](implicit F: Functor[F]): Invariant[Queue[F, ?]] = | |||
There was a problem hiding this comment.
Not sure what are the implication of using Functor vs CatsFunctor here...
|
👍 We should probably add |
|
@OlivierBlanvillain Can you update this PR to use |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you think it would make sense to have an
Invariant[mutable.Queue]? I might make more sense to defineimap/xmapdirectly on the queue and do a simple forward infs2-cats/fs2-scalaz.