Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rrule parsing if start date (DTSTART) includes timezone (TZID) #7223

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaelKaefer
Copy link

Replaces #7044 (aborted because of merge conflicts)
Fixes #6932

Right now, without this fix the folllowing event has no start time and defaults to all day because of ;TZID=Europe/Vienna:

      events: [
        {
          rrule: 'DTSTART;TZID=Europe/Vienna:20221029T150000\nRRULE:FREQ=DAILY;COUNT=2',
        },
      ],

…ZID) the time is recognized (does not default to all day)
@michaelKaefer
Copy link
Author

@arshaw This is my second attempt, would be really appreciated if you could merge this small fix.

@michaelKaefer michaelKaefer changed the title fix rrule parsing: if the start date (DTSTART) includes a timezone fix rrule parsing if the start date (DTSTART) includes a timezone Feb 23, 2023
@michaelKaefer michaelKaefer changed the title fix rrule parsing if the start date (DTSTART) includes a timezone fix rrule parsing if start date (DTSTART) includes a timezone (TZID) Feb 23, 2023
@michaelKaefer michaelKaefer changed the title fix rrule parsing if start date (DTSTART) includes a timezone (TZID) fix rrule parsing if start date (DTSTART) includes timezone (TZID) Feb 23, 2023
@Godefroy
Copy link

Thanks for this fix 🙏 I used it to patch my project with patch-package while waiting for this PR to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events with timezone TZID in DTSTART and no UNTIL (infinite) show as All-Day
2 participants