Custom headers - Possible Implementation #6690
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I gave a stab at implementing #4627 / updates for #6683 and this seems to be working for my use case now, and lets users pass additional headers to event source configurations. This lets you set Authorization headers for JSON / iCalendar / Google Calendar feeds.
I didn't run the tests / update tests, because I'm simply trying this out on my project as this functionality being missing is a direct blocker to work that I am currently trying to implement. Pushing this PR so the maintainers can review and take if you would like, it really seems like an easy addition with a lot of added benefits.
Should work for JSON, Google Calendar, and iCalendar feeds, but I'm only using iCalendar on my project. I'm not familiar enough with the fullcalendar source to guarantee this change works across all event sources as intended, but it is now definitely letting me pass an auth header for an ics feed.
@acerix FYI