Fix sorting of resources with numbers (numberish) titles #6426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have encountered a possible bug. The bug is when we pass to
<FullCalender />
react component (timeline view) resourceswith titles as numbers or numberish strings like
{ title: 2 }
or{ title: '2' }
.Resolves #6427
My best guess is that in this case the last
if
statement in theflexibleCompare
function gets executed. The problem is thatString.localeCompare
returns wrong values, f.e the following example returns1
but this return
-1
:However, they should return the same value for sorting to work as expected.
You can find a runnable demo in this repo.
There is also a codesandbox with reduced example.
It looks like this:
It also can be solved by providing
{numeric: true}
as config param tolocaleCompare
, but I am not sure which locale to pass in this case.