Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIS AWS IAM password policy rules #72

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CIS AWS IAM password policy rules #72

wants to merge 3 commits into from

Conversation

ismailyenigul
Copy link
Contributor

also updated README.md with rule id.
It seems rule ids are unordered. Is there any pattern for ID?

@ismailyenigul
Copy link
Contributor Author

I did not want to create separate test files for each iam password policy checks. But it seems check-naming.sh expect a test file for each rule.

jaspervdj-luminal
jaspervdj-luminal approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@jaspervdj-luminal jaspervdj-luminal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! I'll relax the naming check and check what we should do about the rule numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaspervdj-luminal jaspervdj-luminal jaspervdj-luminal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ismailyenigul @jaspervdj-luminal