Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use nuget CPM to enable strict package reference on direct dependencies #4253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

antymon4o
Copy link
Contributor

This PR fixes issue references: strict either does not work, or does not work as expected
#2257

In Paket.Restore.targets based on ManagePackageVersionsCentrally property:

  • add condition on Package reference to include direct only packages
  • add condition on Version element to be used only when ManagePackageVersionsCentrally not is enabled
  • add package version items for all the packages in ref file

In RestoreProcess.fs - the changes are similiar to those in Paket.Restore.targets

…es only fsprojects#2257

In Paket.Restore.targets based on ManagePackageVersionsCentrally property:
 - add condition on Package reference to include direct only packages
 - add condition on Version element to be used only when ManagePackageVersionsCentrally not is enabled
 - add package version items for all the packages in ref file

In RestoreProcess.fs - the changes are similiar to those in Paket.Restore.targets
@antymon4o
Copy link
Contributor Author

antymon4o commented Apr 1, 2024

@forki @agross
Is it possible for you to have a look at this PR and tell you opinion on the approach?
Thank you very much! 😊

@antymon4o
Copy link
Contributor Author

👋 @forki, can I draw your attention to this PR, please? Or if someone else can review this PR, would you forward it or tag him/her? I would greatly appreciate any attention. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant