Split out Watcher and backends #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arp242
force-pushed
the
backend
branch
2 times, most recently
from
de770b8
to
3fa20e8
Compare
Rather than have a bunch of Watcher types guarded by build tags, have one Watcher that's always available which proxies to a backend interface. This will allow adding a polling watcher, fanotify, fsevents, and things like that. There are no backends to select from yet, and I'm not 100% sure yet what an API for that would look like, but this sets up the scaffolding for all of it. Backends are per-watcher; originally I prototyped something that allows selecting it per-Add() call, but the bookkeeping on that became rather complex, and this use case is probably far too rare to spend a lot of effort on. People can still use different backends by using different Watchers; they'll just have to do the bookkeeping themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than have a bunch of Watcher types guarded by build tags, have one Watcher that's always available which proxies to a backend interface.
This will allow adding a polling watcher, fanotify, fsevents, and things like that. There are no backends to select from yet, and I'm not 100% sure yet what an API for that would look like, but this sets up the scaffolding for all of it.
Backends are per-watcher; originally I prototyped something that allows selecting it per-Add() call, but the bookkeeping on that became rather complex, and this use case is probably far too rare to spend a lot of effort on. People can still use different backends by using different Watchers; they'll just have to do the bookkeeping themselves.