Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive history #2136

Merged
merged 4 commits into from
May 16, 2024
Merged

Archive history #2136

merged 4 commits into from
May 16, 2024

Conversation

chengxi600
Copy link
Contributor

@chengxi600 chengxi600 commented May 15, 2024

Describe your changes

/archive path also shows TabArtifacts on Archive Page

Issue or discord link

Resolves #2125

Testing/validation

archive.history.mov

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented May 15, 2024

[frontend] [Wed May 15 08:55:15 UTC 2024] - Deployed f0d804e to https://genshin-optimizer-prs.github.io/pr/2136/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed May 15 20:33:15 UTC 2024] - Deployed acc833e to https://genshin-optimizer-prs.github.io/pr/2136/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed May 15 20:38:04 UTC 2024] - Deployed 2fe71d1 to https://genshin-optimizer-prs.github.io/pr/2136/frontend (Takes 3-5 minutes after this completes to be available)

[Thu May 16 06:54:28 UTC 2024] - Deleted deployment

@chengxi600 chengxi600 marked this pull request as ready for review May 15, 2024 08:58
Copy link
Owner

@frzyc frzyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@frzyc frzyc merged commit 283e14f into frzyc:master May 16, 2024
6 checks passed
@chengxi600 chengxi600 deleted the archive-history branch May 17, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archive page needs to have browser history friendly routing
2 participants