Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experiment] add character info to Loadout Tab bar #2083

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented May 9, 2024

Describe your changes

Loadout UI doesn't really indicate which character you are on, That's why a lot of the tabs have a "character UI" in the top left above the fold. (overview, opt tab) However, this is using up valuable space that can be used to display more relevant information. I want to experiment with adding a more "static" element, rather than one baked into each page.
This PR adds a persistent character element to the loadout tab element, which shows the character and some metadata.
This is also clickable, so it can provide a editor for some char stats like level/talent

Issue or discord link

Testing/validation

Before
image

After
image

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Copy link
Contributor

github-actions bot commented May 9, 2024

[frontend] [Thu May 9 16:51:20 UTC 2024] - Deployed 78e2800 to https://genshin-optimizer-prs.github.io/pr/2083/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu May 16 05:02:21 UTC 2024] - Deployed 4e332e5 to https://genshin-optimizer-prs.github.io/pr/2083/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon May 20 07:50:22 UTC 2024] - Deployed 7a34e4c to https://genshin-optimizer-prs.github.io/pr/2083/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed May 22 14:11:56 UTC 2024] - Deployed a899c8c to https://genshin-optimizer-prs.github.io/pr/2083/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed May 22 17:42:58 UTC 2024] - Deployed 7f1c475 to https://genshin-optimizer-prs.github.io/pr/2083/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Wed May 22 17:54:13 UTC 2024] - Deployed ed3f210 to https://genshin-optimizer-prs.github.io/pr/2083/frontend (Takes 3-5 minutes after this completes to be available)

@frzyc frzyc changed the title [Experiment] add character info to Loadout UI [Experiment] add character info to Loadout Tab bar May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant