This repository has been archived by the owner on Feb 19, 2020. It is now read-only.
removed the restriction on the @ in the user field of the JID #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…patibility with FB non-standard JID form
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facebook's XMPP server is non-standard, but if you want to use PLAIN auth with their servers and log in with your FB email address your JID becomes user@email.com@chat.facebook.com where the JID user is user@email.com and the domain is chat.facebook.com. Removing this restriction allows you to use SleekXMPP with FB in this manner for auth. Needed it for a project, and thought others might run into this issue as well. This restriction catches auth errors on the client before going to the server, but it limits this API's ability to interface with services that use this type of auth. My recommendation is leave the error checking for this particular case to the server and enable compatibility with more services.