Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes & improvements #44

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

alessandrocraeye
Copy link
Contributor

No description provided.

Only return if both the sort dropdown & filters aren't found. Otherwise the product sort dropdown is shown but won't work if there are no available filters.
Adds a setting that enables easy switching between showing all prices with VAT included or excluded.
Product prices in cart are shown excluding VAT since a full VAT calculation is shown at the bottom.
Cookies with SameSite=None must now also specify the Secure attribute (they require a secure context/HTTPS).
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite#fixing_common_warnings
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 6.41% // Head: 6.38% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (203891b) compared to base (de74151).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             master     #44      +/-   ##
===========================================
- Coverage      6.41%   6.38%   -0.03%     
- Complexity     3419    3423       +4     
===========================================
  Files           467     467              
  Lines         16618   16646      +28     
===========================================
- Hits           1066    1063       -3     
- Misses        15552   15583      +31     
Impacted Files Coverage Δ
src/Backend/Modules/Commerce/Domain/Cart/Cart.php 29.69% <0.00%> (ø)
...nd/Modules/Commerce/Domain/Cart/CartRepository.php 0.00% <0.00%> (ø)
...kend/Modules/Commerce/Domain/CartRule/CartRule.php 0.00% <0.00%> (ø)
...rce/Domain/CartRule/CartRuleDataTransferObject.php 0.00% <0.00%> (ø)
...es/Commerce/Domain/CartRule/CartRuleRepository.php 0.00% <0.00%> (ø)
.../Modules/Commerce/Domain/CartRule/CartRuleType.php 0.00% <0.00%> (ø)
.../Modules/Commerce/Domain/Product/AddToCartType.php 0.00% <0.00%> (ø)
.../Commerce/Domain/ProductSpecial/ProductSpecial.php 51.42% <0.00%> (-2.42%) ⬇️
...merce/Domain/ProductSpecial/ProductSpecialType.php 0.00% <0.00%> (ø)
.../Domain/Settings/Command/UpdateSettingsHandler.php 0.00% <0.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jessedobbelaere jessedobbelaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants